Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose thumbnails on works if the only restrictions are on the physical items #5416

Closed
alexwlchan opened this issue Jan 19, 2022 · 3 comments

Comments

@alexwlchan
Copy link
Contributor

Quoting Branwen in Slack:

I was wondering why a thumbnail image sometimes appears on Works and other times not? We recently ingested a set of 10 Royal Botanic Gardens prints, but only one has a thumbnail - https://wellcomecollection.org/works/xfq9r7ym (b32890783)
The others appear like this: https://wellcomecollection.org/works/u6snm6q6 (b32890345)

@alexwlchan
Copy link
Contributor Author

Okay, so I went to have a look at this.

b32890345 is a combination of Sierra physical bib and a METS work, which has two items:

  • a physical item, which has the access status "by appointment"
  • a digitised item, which has the access status "open"

The merger suppresses thumbnails if any of the items on the work have restrictions, but in this case I think it's being overzealous – although the physical item has restrictions, we should be fine to display a digitised thumbnail.

I think we should suppress thumbnails only if the digitised item (i.e. the METS work) has restrictions.

I'm going to leave this ticket for now, with two notes:

  1. @jtweed should confirm if that's the correct behaviour
  2. if it is the correct behaviour, this would be a good first merger patch for somebody

@alexwlchan alexwlchan changed the title Why do some works have thumbnails, but others don't? Expose thumbnails on works if the only restrictions are on the physical items Feb 21, 2022
@jtweed
Copy link
Contributor

jtweed commented Feb 21, 2022

I think that's the correct behaviour, ie the thumbnail restrictions should come from the digitised work not the physical work.

@alexwlchan
Copy link
Contributor Author

Paul fixed this!

Repository owner moved this from Archive to Done in Digital platform Jul 4, 2022
@pollecuttn pollecuttn moved this from Done to Archive in Digital platform Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants