Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items API responds with available dates (hardcoded for now) #741

Closed
kenoir opened this issue Jan 22, 2024 · 1 comment
Closed

items API responds with available dates (hardcoded for now) #741

kenoir opened this issue Jan 22, 2024 · 1 comment
Assignees

Comments

@kenoir
Copy link
Contributor

kenoir commented Jan 22, 2024

When requesting an item currently we work out the available dates in the wellcomecollection.org codebase (https://github.com/wellcomecollection/wellcomecollection.org/blob/main/content/webapp/components/ItemRequestModal/RequestDialog.tsx#L143).

In order to sustainably provide availability dates when items can be requested from offsite locations we should move to incorporate these into the items API response, optionally available with a suitable request parameter.

This is to support the offsite-requesting work where we will need to consider items requested with differing date constraints for each offsite-location.

@kenoir
Copy link
Contributor Author

kenoir commented Jan 22, 2024

We expect this may require querying data on opening times from prismic (or perhaps proxied through the content-api).

@kenoir kenoir moved this from Backlog to Next in Digital experience Jan 22, 2024
@agnesgaroux agnesgaroux self-assigned this Feb 13, 2024
@agnesgaroux agnesgaroux moved this from Backlog to In progress in Digital platform Feb 13, 2024
@agnesgaroux agnesgaroux changed the title Move calculating available dates for item requesting to the items API items API responds with available dates (hardcoded for now) Mar 4, 2024
@agnesgaroux agnesgaroux moved this from In progress to Ready for review in Digital platform Mar 4, 2024
@agnesgaroux agnesgaroux moved this from Ready for review to Blocked in Digital platform Mar 5, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Digital platform Mar 5, 2024
@pollecuttn pollecuttn moved this from Done to Archive in Digital platform Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants