Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optics-0.4 release #375

Closed
phadej opened this issue Dec 23, 2020 · 10 comments
Closed

optics-0.4 release #375

phadej opened this issue Dec 23, 2020 · 10 comments

Comments

@phadej
Copy link
Contributor

phadej commented Dec 23, 2020

I'm very eager to use indexed-traversable.

I haven't followed the LabelOptic changes, is the #365 only things left?

Does @adamgundry or @arybczak have some breaking changes in mind, which would be great to get in?

I think it would be great to have GHC-9.0 compatible release as soon as it is released, so that could be a (soft) deadline for optics-0.4.

@arybczak
Copy link
Collaborator

Apart from #365 I need to port a bit from ekmett/lens#945. Other than that I think it's good to go.

@adamgundry
Copy link
Member

Sorry, I haven't been keeping up because of "holidays", but I'm supportive of releasing optics-0.4 around the GHC-9.0 release if not before. I'll try to find an opportunity to properly review the recent changes in the next week or so. But I don't have anything that is urgent to land before a release.

@phadej
Copy link
Contributor Author

phadej commented Feb 11, 2021

GHC-9.0 is released.

@arybczak
Copy link
Collaborator

I suggest merging #399 and getting a release out.

@adamgundry
Copy link
Member

Sounds good to me!

@adamgundry
Copy link
Member

adamgundry commented Feb 18, 2021

We don't have CI for GHC 9.0.1 yet (haskell-CI/haskell-ci#474), but I've verified locally that the main packages build and pass tests.

Still lacking:

  • optics-sop is blocked by A release for GHC-9.0 generics-sop#130 (but isn't released anyway)
  • template-haskell-optics needs to be amended to support template-haskell-2.17.0.0
  • Benchmarks don't build because of dependency bounds, but they can be persuaded to with enough allow-newer.

As far as I can see we need to:

  • Upload 0.4 releases of optics-core, optics-th, optics-extra and optics to Hackage.
  • Relax the bounds of the released optics-vl to permit optics-core-0.4.
  • Add release tag.

I'm going to open a PR with some minor changelog fixes. Provisionally I'm planning to make a release early next week. Anything else we need to do first?

@phadej
Copy link
Contributor Author

phadej commented Feb 21, 2021

I tested some small developments, and at least optics-core package doesn't break anything unexpectedly there

@adamgundry
Copy link
Member

I've made the release.

@phadej
Copy link
Contributor Author

phadej commented Feb 22, 2021

Hurray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants