Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dts.config.ts #132

Merged
merged 3 commits into from
Feb 14, 2022
Merged

feat: add support for dts.config.ts #132

merged 3 commits into from
Feb 14, 2022

Conversation

ToppleTheNun
Copy link

@ToppleTheNun ToppleTheNun commented Feb 10, 2022

attempts to load dts.config.ts if it is available,
throws an error if unable to load it. if dts.config.ts
isn't available, moves on to check for dts.config.js.

enables type declarations in tsconfig.json so that
people can import types correctly.

might be worth splitting the current index.ts into multiple
files: one that effectively handles exporting all of the types
(index.ts) and one that handles the CLI itself (cli.ts). this
would be inline with how the templates used by the project
split things.

closes #128

@ToppleTheNun ToppleTheNun marked this pull request as ready for review February 10, 2022 04:29
@aladdin-add aladdin-add self-requested a review February 10, 2022 06:36
attempts to load dts.config.ts if it is available,
throws an error if unable to load it. if dts.config.ts
isn't available, moves on to check for dts.config.js.

enables type declarations in tsconfig.json so that
people can import types correctly.

this commit does not include documentation about how
to use dts.config.ts as type exports should probably
be revisited.

closes #128
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM, thanks!

@aladdin-add aladdin-add merged commit a5b4365 into weiran-zsd:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support dts.config.ts
2 participants