Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4D Rotor Normalization #18

Open
markomih opened this issue Oct 17, 2024 · 3 comments
Open

4D Rotor Normalization #18

markomih opened this issue Oct 17, 2024 · 3 comments

Comments

@markomih
Copy link

Dear authors,

Thank you for sharing this excellent work and for providing the code!

I noticed that the function slice_4d doesn't appear to implement 4D rotor normalization as described in Section A.1 of the Supplementary Materials. Could you please clarify the reasoning behind this, or if there are any specific considerations that led to this decision?

I’d greatly appreciate any insights you can provide.

Best regards,
Marko

@weihan1
Copy link

weihan1 commented Jan 6, 2025

same question, @markomih did you end up resolving this?

@markomih
Copy link
Author

markomih commented Jan 6, 2025

I didn't @weihan1 . Maybe @weify627 can comment on this?

@weihan1
Copy link

weihan1 commented Jan 6, 2025

I tested on the bouncing balls scene with and without the normalization and the quality of the rendered images didn't seem to be too different for that scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants