ngx_print_escape 函数只在 NGX_HTTP_UPSTREAM_CHECK 开启时定义 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, gcc will report an unused-function error
|
yeah, great, thanks! 之前的策略是支持把upstream 的配置dump 的本地，目的：保持远程与本地server配置的一致性，降低nginx 对配置中心的依赖性，在配置中心出问题时，可以随时的本地reload。 当前只支持consul，为了便于添加其它的配置服务，做了一个架构调整，见分支：https://github.com/weibocom/nginx-upsync-module/tree/support_other_conf_server ； 这个分支已通过测试，添加些回归测试用例，便会merge 到主分支；欢迎提交对其它配置服务的pr（etcd、zk...）thanks |
Closed
Open
This was referenced Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx_print_escape 函数只在 NGX_HTTP_UPSTREAM_CHECK 开启时定义，否则gcc会报一个「定义后未使用」的错误，而且该函数只在NGX_HTTP_UPSTREAM_CHECK开启的时候才会被调用，所以将函数定义也放在upstream check中也更合适。