Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Chromecast logic & typo #175

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Conversation

OsmanAltun
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Changed if (argv.chromecast !== false) { to if (argv.chromecast) {, so the chromecast logic doesn't execute.
(I don't have chromecast, so that's why I probably didn't have any issues, but this should fix it)

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?
Nope.

@DiegoRBaquero DiegoRBaquero merged commit 8234278 into webtorrent:master Jul 14, 2021
webtorrent-bot pushed a commit that referenced this pull request Jul 14, 2021
## [3.3.2](v3.3.1...v3.3.2) (2021-07-14)

### Bug Fixes

* Chromecast logic & typo ([#175](#175)) ([8234278](8234278))
@webtorrent-bot
Copy link

🎉 This PR is included in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@OsmanAltun OsmanAltun deleted the fix/#173 branch July 15, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'toLowerCase' of undefined
3 participants