feat: add playlist option #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
Hi! Can you please re-base? I can review after it's clean |
loiccoyle
commented
Jul 10, 2021
|
I merged upstream. I also fixed a typo in the |
DiegoRBaquero
approved these changes
Jul 15, 2021
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
# [3.5.0](v3.4.1...v3.5.0) (2021-07-15) ### Features * add playlist option ([#168](#168)) ([a003e7e](a003e7e))
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Nice ! Thanks ! |
|
I think this would work better if we generated an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I added the --playlist option which will open all the urls of the files in the torrent in a playlist in supported players. I could only get
mpv,mplayerandvlcworking. If you know how to do this for any of the other players I'm all ears.Which issue (if any) does this pull request address?
#166
Is there anything you'd like reviewers to focus on?
I didn't test the
vlcon windows, its probably a good idea to do so. This option is most likely incompatible with the--subtitlesoption, I didn't enforce it though, maybe it should be checked and enforced?I don't have much experience with JS so if I'm not following best practices, feel free to correct me!