Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use dataLength #2004

Merged
merged 3 commits into from
Jan 14, 2022
Merged

fix: use dataLength #2004

merged 3 commits into from
Jan 14, 2022

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Jan 14, 2022

No description provided.

@ronag
Copy link
Contributor Author

ronag commented Jan 14, 2022

Minor bug when passing strings, we shouldn't look at the string char length but it's byte length

ronag
ronag commented Jan 14, 2022
View reviewed changes
lib/sender.js Outdated Show resolved Hide resolved
lpinca
lpinca reviewed Jan 14, 2022
View reviewed changes
lib/sender.js Show resolved Hide resolved
lib/sender.js Outdated Show resolved Hide resolved
@ronag ronag requested a review from lpinca January 14, 2022 12:27
@lpinca
Copy link
Member

lpinca commented Jan 14, 2022

Thank you. I will merge this and cut a new release later.

@lpinca lpinca merged commit 0c0754b into websockets:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @lpinca