Node server keeps crashing repeatedly with "Error: reserved fields must be empty"

[booboothefool]

This started happening suddenly, and now I can't even get my server back up. It's been a few hours. it just restarts, then immediately crashes.

Any ideas?

[lpinca]

Add an error listener to your WebSocket objects and handle the error.

wss.on('connection', (ws) => {
  ws.on('error', (err) => handleError(err));
});

This error is raised when the client sends a frame with one or more reserved bit on. It can happen because the client is broken or because a bad actor is sending invalid frames with the aim of crashing your server.

[booboothefool]

@lpinca Do you have any advice on how to implement this with this library?

https://github.com/apollographql/subscriptions-transport-ws

It looks like I'd do something like this:

new SubscriptionServer(
  {
    subscriptionManager,
    keepAlive: 20000,
    onConnect: async (connectionParams, webSocket) => {
      webSocket.on('error', err => console.error(err));
    },
  },
  {
    server: websocketServer,
    path: '/',
  }
);

which does not seem to be helping as the server continues to crash with "reserved fields must be empty".

[lpinca]

What you wrote in this comment apollographql/subscriptions-transport-ws#94 (comment) seems correct to me. There should be an error listener there.

[booboothefool]

@lpinca Yes, after I made sure the change was in:

Wrong:

new SubscriptionServer(
  {
    subscriptionManager,
    keepAlive: 20000,
    onConnect: async (connectionParams, webSocket) => {
      webSocket.on('error', err => console.error(err));
    },
  },
  {
    server: websocketServer,
    path: '/',
  }
);

Correct:
https://github.com/apollographql/subscriptions-transport-ws/blob/master/src/server.ts#L96

            request.on('error', function (err) {
                console.error(err);
            });

It is catching the error, and no longer crashing. All is well now. Thanks so much.