Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy binaries for Apple Silicon #135

Closed
chenrui333 opened this issue Aug 20, 2021 · 4 comments
Closed

Deploy binaries for Apple Silicon #135

chenrui333 opened this issue Aug 20, 2021 · 4 comments

Comments

@chenrui333
Copy link

It looks like whatever change which fixes #131 did not include the prebuilt binary for apple silicon (aarm64). Let me know if I missed anything, thanks!

@lpinca
Copy link
Member

lpinca commented Aug 21, 2021

Correct, a prebuilt binary for Apple silicon is not included. There is one for ARM64 but it is for Linux. I'm not sure if there is an easy way to cross compile for Apple silicon in GitHub Actions.

@lpinca
Copy link
Member

lpinca commented Aug 21, 2021

I think this is blocked by actions/runner-images#2187.

@lpinca
Copy link
Member

lpinca commented Aug 21, 2021

We could build a universal binary as discussed in Level/leveldown#766. This is how fsevents does it: fsevents/fsevents#350. However it is blocked by prebuild/prebuildify#52.

@chenrui333
Copy link
Author

I think a universal binary would be a much better approach, we can simplify the homebrew audit check (as we did for fsevents)

@lpinca lpinca closed this as completed in bedfb2c Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants