Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont rely on prefixed mozGetUserMedia and mozRTCPeerConnection for Firefox detection #151

Closed
fippo opened this issue Nov 12, 2015 · 3 comments

Comments

@fippo
Copy link
Member

fippo commented Nov 12, 2015

from the Firefox 44 release notes: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/discuss-webrtc/C7rTpqdAQ6o/Ig86CPxxAgAJ it looks like we need another way to detect Firefox in https://github.com/webrtc/adapter/blob/0f06144afc30ac5e92de3c47955ecb835524ee79/adapter.js#L91

@mreavy @jan-ivar: do you have a recommended way for detection? I suppose we could snoop on the UA string and also check for the unprefixed versions but there might be a better way.

We are also using mozRTCPeerConnection and mozGetUserMedia inside the wrappers:
https://github.com/webrtc/adapter/blob/0f06144afc30ac5e92de3c47955ecb835524ee79/adapter.js#L130
https://github.com/webrtc/adapter/blob/0f06144afc30ac5e92de3c47955ecb835524ee79/adapter.js#L198

@jan-ivar
Copy link
Collaborator

Note that we unprefixed everything but navigator.mozGetUserMedia. This was intentional, as we want people to use navigator.mediaDevices.getUserMedia instead.

@jan-ivar
Copy link
Collaborator

In addition, the prefixed versions will continue to exist for a couple of releases, but now is a good time to prepare. We should probably refactor things in a way that works for both old and new.

@fippo
Copy link
Member Author

fippo commented Feb 10, 2016

#164 only uses navigator.mozGetUserMedia -- see also https://github.com/webrtc/adapter/pull/164#discussion_r52477419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants