Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice processing optimizations #150

Open
wants to merge 10 commits into
base: m125_release
Choose a base branch
from
Open

Voice processing optimizations #150

wants to merge 10 commits into from

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Oct 14, 2024 •
edited
Loading

  1. This reverts commit c0209ef.
  2. Uses Mute API instead of restarting AudioUnit when mute/unmuted.
  3. Init AudioUnit with input enabled & muted when mic perms are already granted.

@hiroshihorie hiroshihorie marked this pull request as ready for review October 17, 2024 19:36
@hiroshihorie hiroshihorie mentioned this pull request Oct 22, 2024
Open
cloudwebrtc
cloudwebrtc approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hiroshihorie hiroshihorie mentioned this pull request Oct 23, 2024
Draft
@davidliu
Copy link
Contributor

Will this affect the android mic indicator?

@hiroshihorie
Copy link
Member Author

This shouldn't affect Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiroshihorie @davidliu @cloudwebrtc