Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARC-Protocol + WARC-Cipher-Suite headers #715

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

WARC-Protocol + WARC-Cipher-Suite headers #715

wants to merge 6 commits into from

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 7, 2024 •
edited by tw4l
Loading

A few caveats:

  • The WARC-Cipher-Suite data is not directly available from the browser, so must be inferred based on the available info.

@ikreymer
- add WARC-Protocol header combining http + tls protocols as comma se…
ab45429 
…parated

- add WARC-Cipher-Suite header, mapping Chrome NetworkSecurityDetails to known cipher suites
- fixes #641
@ikreymer
cleanup, add fallbacks for tls/1.3 to common cipher values
764930b
@tw4l
Copy link
Member

tw4l commented Nov 11, 2024

Re: the WARC-Protocol header being comma separated rather than repeated, it looks like the IIPC membership is trying to get consensus on whether this is acceptable this week. See ongoing discussion here: iipc/warc-specifications#42

tw4l
tw4l reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion re: import cleanup.

Community consensus in iipc/warc-specifications#42 seems to be for repeated headers rather than a single header with a comma-separated list so we should probably modify this PR to go with that approach.

src/util/reqresp.ts Outdated Show resolved Hide resolved
@ikreymer
update to latest warcio
1a185de 
support WARC-Protocol as multiple headers
tests: add tests for WARC-Protocol, WARC-Cipher-Suite
@ikreymer ikreymer requested a review from tw4l November 20, 2024 19:48
@ikreymer ikreymer marked this pull request as ready for review November 20, 2024 19:50
@ikreymer @tw4l
Update src/util/reqresp.ts
b180e31 
Co-authored-by: Tessa Walsh <[email protected]>
@ikreymer
Copy link
Member Author

One suggestion re: import cleanup.

Community consensus in iipc/warc-specifications#42 seems to be for repeated headers rather than a single header with a comma-separated list so we should probably modify this PR to go with that approach.

Updated to now generate multiple WARC-Protocol headers, per consensus there.

@ikreymer
Copy link
Member Author

Though, may also want to get clarification on WARC-Cipher-Suite since its not an exact one-to-one mapping there..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for WARC-Protocol and WARC-Cipher-Suite headers
2 participants
@ikreymer @tw4l