fix(plugin/babel): bypass directly required plugins or presets in babel config #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 This pull request is included in v5.9.2. See Release 5.9.2 for release notes. Using Knip in a commercial project? Please consider sponsoring me. |
|
Thanks @mridgway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel supports importing or directly declaring plugins in the JS configuration. Currently
knipwill throw an error trying to parse the plugin name if a plugin/preset is directly imported.Example config directly from babel monorepo: https://github.com/babel/babel/blob/main/babel.config.js#L199
I'm not sure if
knipwill actually handle therequire/importin JS babel configs yet, but this at least makes it not throw.