Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefinePlugin cross-compatibility #13138

Closed
wants to merge 2 commits into from
Closed

DefinePlugin cross-compatibility #13138

wants to merge 2 commits into from

Conversation

jsg2021
Copy link

@jsg2021 jsg2021 commented Apr 14, 2021

Just updated node modules today, and Storybook started crashing.. the newer webpack exposed where my webpack config used builtin plugins shared to the webpack config of their builder (and presumably their core). My config's plugin instances come from webpack5... However, storybook-core still builds on webpack 4... (its nested under storybook's node_modules)

This change allows the plugin to continue functioning in webpack 4.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra
Copy link
Member

sokra commented Apr 14, 2021

We don't provide support for using the webpack 5 DefinePlugin in a webpack 4 build.

@sokra sokra closed this Apr 14, 2021
@jsg2021 jsg2021 deleted the patch-1 branch April 14, 2021 17:46
@johnnybenson
Copy link

This change hurts nothing and makes the software more resilient.

@alexander-akait
Copy link
Member

It will not fix nothing, webpack v4 compiler is not the same webpack v5 compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants