Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay gets stuck on first failed compilation #824

Closed
ludofischer opened this issue Mar 1, 2017 · 8 comments
Closed

Error overlay gets stuck on first failed compilation #824

ludofischer opened this issue Mar 1, 2017 · 8 comments
Labels

Comments

@ludofischer
Copy link
Contributor

Do you want to request a feature or report a bug?
A bug.

What is the current behavior?
When a change to a file to solve a compilation error introduces a different compilation error, the error overlay keeps showing the first error, even if the console output correctly reports the new error.

If the current behavior is a bug, please provide the steps to reproduce.

From the webpack.config.js entry point, import an ES6 module containing a syntax error. The error overlay displays the error. Change the imported module to contain a different syntax error. Now the error overlay keeps displaying the old error.

What is the expected behavior?
The error overlay should display the new error.

Please mention your webpack and Operating System version.
webpack 2.2.1, Fedora 25.

@SpaceK33z
Copy link
Member

Please ensure you are on the latest version of webpack dev server. Something like this was fixed in the latest version.

@ludofischer
Copy link
Contributor Author

I’m using 2.4.1, which should be the latest. Is this the commit that should fix the issue?

@SpaceK33z
Copy link
Member

Yes. Can you reproduce it using this example (clone the repo, npm i and read the instructions in the README of the example)?

@ludofischer
Copy link
Contributor Author

I’ll try. Do you think it could be related to using node 7.6 intead of 6 to run webpack-dev-server?

@ludofischer
Copy link
Contributor Author

ludofischer commented Mar 1, 2017

I can’t reproduce the problem with the simple setup in the repository, but it keeps happening in my own project.
Here is my webpack config: https://gist.github.com/ludovicofischer/a44babb411341937868fccc3d768a726. I run iwebpack-dev-server with this npm script:

NODE_ENV=development webpack-dev-server --open"

Could eslint-loader interfere with proper reloading? I notice other strange things, like sometimes the error overlay disappears but old page stays (the page does not seem to reload) and some error messages that appear in the console are missing completely in the overlay.

@SpaceK33z
Copy link
Member

@ludovicofischer do you also have the issue when using enforce: "pre" (see eslint-loader readme)?

@ludofischer
Copy link
Contributor Author

I tested enforce: pre and it doe not change anything. I still cannot reproduce the issue reliably. I tried repeating exactly the same edits and one the overlay updates and another time it gets stuck.

@shellscape
Copy link
Contributor

Pruning due to age, inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants