Issue 4630/replace default gateway #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdikhashan
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
|
Please remove unrelated changes, thank you |
mahdikhashan
force-pushed
the
issue-4630/replace-default-gateway
branch
from
dab3db4
to
d744c9e
Compare
mahdikhashan
force-pushed
the
issue-4630/replace-default-gateway
branch
from
d744c9e
to
b5784a1
Compare
done. |
| * @param {string} gateway | ||
| * @returns {string | undefined} | ||
| */ | ||
| static findIp(gateway) { |
There was a problem hiding this comment.
We need to keep this function, because developer still can use it, otherwise it is a breaking change
There was a problem hiding this comment.
ok, I'll change my changes.
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5255 +/- ##
==========================================
- Coverage 90.29% 84.99% -5.31%
==========================================
Files 15 16 +1
Lines 1577 1693 +116
Branches 601 635 +34
==========================================
+ Hits 1424 1439 +15
- Misses 140 227 +87
- Partials 13 27 +14 ☔ View full report in Codecov by Sentry. |
|
/cc @snitin315 Feel free to merge when CI will be green, locally all tests are passed |
snitin315
approved these changes
Aug 7, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
there are failing tests in #5080 which will be fixed and new tests will be added in case.
Motivation / Use-Case
fixes #4630
Breaking Changes
Additional Info