-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace :: with localhost before openBrowser() #4856
fix: replace :: with localhost before openBrowser() #4856
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4856 +/- ##
==========================================
+ Coverage 91.72% 91.85% +0.12%
==========================================
Files 16 16
Lines 1704 1706 +2
Branches 647 649 +2
==========================================
+ Hits 1563 1567 +4
+ Misses 130 128 -2
Partials 11 11
☔ View full report in Codecov by Sentry. |
ac971bd
to
436bbd4
Compare
@alexander-akait, @snitin315. Thank you for reviewing! Please let me know if I need to rebase the commit or do anything else before getting the PR merged. |
We will merge this once CI is green. |
For Bugs and Features; did you add new tests?
test/server/open-option.test.js is modified.
Motivation / Use-Case
This PR resolves #4855. See #4855 for more details.
Breaking Changes
N/A
Additional Info
Below are the screencasts showing the fix on Windows and GitHub Codespaces.
Windows:
windows-before-fix.mov
windows-after-fix.mov
GitHub Codespaces:
codespaces-before-fix.mov
codespaces-after-fix.mov