Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more static option related cli flags #3238

Merged
merged 6 commits into from
May 1, 2021
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 1, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP

Motivation / Use-Case

Add more cli flags related to static option:

  • --static-directory
  • --static-public-path
  • --static-serve-index
  • --static-watch

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 changed the title [WIP] feat: add more static option related cli flags feat: add more static option related cli flags May 1, 2021
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #3238 (38e8b03) into master (4b80c98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3238   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          34       34           
  Lines        1231     1231           
  Branches      346      346           
=======================================
  Hits         1174     1174           
  Misses         51       51           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b80c98...38e8b03. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review May 1, 2021 11:01
@alexander-akait alexander-akait merged commit 469e558 into master May 1, 2021
@alexander-akait alexander-akait deleted the static-flags branch May 1, 2021 13:59
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants