Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate error messages on descriptions #3154

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

NA

Motivation / Use-Case

Error messages are unused.

Breaking Changes

No

Additional Info

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #3154 (d606cc1) into master (ad3db67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3154   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          37       37           
  Lines        1218     1218           
  Branches      338      338           
=======================================
  Hits         1157     1157           
  Misses         55       55           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3db67...d606cc1. Read the comment docs.

lib/options.json Outdated Show resolved Hide resolved
@alexander-akait
Copy link
Member

alexander-akait commented Apr 6, 2021

I will finish, also we need to add description for all properties, include nested, for example client.overlay

@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants