fix: hostname resolving #3128
Merged
fix: hostname resolving #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
previously approved these changes
Mar 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
+ Coverage 91.87% 91.95% +0.07%
==========================================
Files 37 37
Lines 1293 1292 -1
Branches 349 349
==========================================
Hits 1188 1188
+ Misses 98 96 -2
- Partials 7 8 +1
Continue to review full report at Codecov.
|
|
@anshumanv can you fix lint issue? |
|
Failing in master, being fixed by @alexander-akait #3129, will rebase |
|
my bad, lint err was genuine, fixed now |
snitin315
approved these changes
Mar 30, 2021
rishabh3112
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
NA
Motivation / Use-Case
Breaking Changes
no
Additional Info
#3112 (comment)