Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings in overlay #3054

Merged
merged 2 commits into from
Feb 28, 2021
Merged

fix: warnings in overlay #3054

merged 2 commits into from
Feb 28, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

tested manually

Motivation / Use-Case

fix warning in console

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #3054 (1f87063) into master (c773d1f) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
- Coverage   92.30%   92.06%   -0.24%     
==========================================
  Files          37       37              
  Lines        1260     1261       +1     
  Branches      327      328       +1     
==========================================
- Hits         1163     1161       -2     
- Misses         92       95       +3     
  Partials        5        5              
Impacted Files Coverage Δ
lib/Server.js 94.44% <ø> (-0.23%) ⬇️
client-src/default/index.js 92.39% <100.00%> (+0.08%) ⬆️
lib/utils/routes.js 94.64% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773d1f...157a479. Read the comment docs.

@alexander-akait
Copy link
Member Author

In future, we need focus on tests, especial e2e with overlay and web sockets

@snitin315 snitin315 merged commit 6144c8d into master Feb 28, 2021
@snitin315 snitin315 deleted the fix-warning-in-overlay branch February 28, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants