Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): enable --overlay #1968

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(config): enable --overlay #1968

merged 1 commit into from
Jun 4, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 4, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Currently, --overlay is not working at master branch. Please try to run examples/cli/overlay.

Breaking Changes

no

Additional Info

@alexander-akait
Copy link
Member

alexander-akait commented Jun 4, 2019

Is it regression?

@hiroppy
Copy link
Member Author

hiroppy commented Jun 4, 2019

@alexander-akait
Copy link
Member

Feel free to merge after CI green

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1968 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   92.55%   92.47%   -0.08%     
==========================================
  Files          28       28              
  Lines        1075     1077       +2     
  Branches      321      322       +1     
==========================================
+ Hits          995      996       +1     
- Misses         76       77       +1     
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/createConfig.js 91.81% <50%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0783a4a...0b5d972. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1968 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   92.55%   92.47%   -0.08%     
==========================================
  Files          28       28              
  Lines        1075     1077       +2     
  Branches      321      322       +1     
==========================================
+ Hits          995      996       +1     
- Misses         76       77       +1     
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/createConfig.js 91.81% <50%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0783a4a...0b5d972. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants