allow us to exclude certain files from the HMR

[aprilmintacpineda]

• Operating System: MacOS
• Node Version: 11.3.0
• NPM Version: 6.5.0
• webpack Version: 4.27.1
• webpack-dev-server Version: 3.1.10

• This is a bug
• This is a modification request

Code

Sorry for not posting my config, I don't think it's related to that.

I'm using worker-loader which basically allows us to turn certain files into separate web worker with fallback capability for devices that does not support web workers.

But once your server starts up, you'll see this error on the console:

The error is coming from the web worker because window is not available on web workers.

Turning off HMR will fix the error BUT I want to be able to use HMR for other stuff. Maybe allow us to provide an option where we could exclude certain files from HMR?

[alexander-akait]

@aprilmintacpineda problem in worker-loader, anyway you need reproducible test repo

[spencer-brown]

web worker's can't use window; this isn't an issue in worker-loader. there's a related issue here.

[alexander-akait]

/cc @spencer-brown sorry for delay, maybe you can create minimum reproducible test repo, it is allow other developers make fast test and search problem place to fix

[alexander-akait]

@masx200 use English language, first warning

[kumar303]

Here is a "minimal" example built with create-react-app:

https://github.com/kumar303/worker-loader-issue174

The readme has instructions. The app gives me: ReferenceError: window is not defined

Other folks have had luck with setting output: { globalObject: 'this' } in a webpack config but it would be nicer if it just worked.

[alexander-akait]

/cc @Loonride @hiroppy we need investigate in problem

[dangreen]

Hi there 👋

This is my solution to disable HMR for workers:
https://github.com/TrigenSoftware/hmr-filter-webpack-plugin#usage

[alexander-akait]

Fixed in worker-loader repo, I don't think we really need to exclude some modules, we should fix compatibility with webpack-dev-server, anyway if you still think we need this, please open an issue in webpack repo, we can't implement this on our side