Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/cli): correct template path in open-page example #1401

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

elrumordelaluz
Copy link
Contributor

Otherwise is returning an Html Webpack Plugin error:

Error: Child compilation failed:
Entry module not found: Error: Can't resolve '/(...)/webpack/webpack-dev-server/examples/assets/layout.html
  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Trying to test the --open behaviour, first approach is to check the example
and seems broken finding a wrong path.

Breaking Changes

Additional Info

Otherwise is returning  an _Html Webpack Plugin_ error:

```
Error: Child compilation failed:
Entry module not found: Error: Can't resolve '/(...)/webpack/webpack-dev-server/examples/assets/layout.html
```
@jsf-clabot
Copy link

jsf-clabot commented May 4, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #1401 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
+ Coverage   79.07%   79.14%   +0.07%     
==========================================
  Files           6        6              
  Lines         497      494       -3     
  Branches      161      160       -1     
==========================================
- Hits          393      391       -2     
+ Misses        104      103       -1
Impacted Files Coverage Δ
lib/util/addDevServerEntrypoints.js 100% <0%> (ø) ⬆️
lib/Server.js 82.26% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5e2f6...7c92138. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title Fix template path in open-page example fix(examples/cli): correct template path in open-page example Aug 21, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky michael-ciniawsky merged commit df30727 into webpack:master Aug 21, 2018
@michael-ciniawsky
Copy link
Member

Released in v3.1.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants