Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1316 #1317

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Fix issue #1316 #1317

merged 1 commit into from
Feb 25, 2018

Conversation

hexpunk
Copy link
Contributor

@hexpunk hexpunk commented Feb 23, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

I did not. I absolutely want to, but it appears that the client-src/default/index.js file has no tests at the moment. Or if it does, I couldn't find them in the test directory.

I would really love some help and/or guidance on how best to test this code.

Motivation / Use-Case

See #1316 for the bug this addresses.

Breaking Changes

There's a possibility that this could cause unnecessary reloads in other situations. I don't think it will, but I'm not 100% sure it won't, especially since this bit of code doesn't seem to have any tests right now.

Additional Info

@hexpunk
Copy link
Contributor Author

hexpunk commented Feb 23, 2018

What's going on with travis-ci? It's been stuck in yellow dot status for 15 hours.

@hexpunk
Copy link
Contributor Author

hexpunk commented Feb 25, 2018

@sokra @shellscape @SpaceK33z Can someone please give travis-ci a kick? It's been stalled for 2 days.

@sokra sokra closed this Feb 25, 2018
@sokra sokra reopened this Feb 25, 2018
@SpaceK33z
Copy link
Member

SpaceK33z commented Feb 25, 2018

Looking into this PR right now (about to release WDS v3)

@SpaceK33z
Copy link
Member

I don't know what is going on with Travis but I'm going to merge this since I confirmed it works locally.

Thanks again @jayandcatchfire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants