-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR logging info message when clientLogLevel is not set to info #1195
Comments
We've got this fixed for the v3 |
Oh nice, thanks. I had a quick look at the v3 branch but couldn't figure out how it was fixed. I think I'll leave it for now as it is not that big of an issue especially if it is solved in v3. Should I close this issue? |
Well it still looks valid for 2.x, so I'd leave it open. And I don't see v3 being released before Feb. |
webpack Version: 4.28.3 with the devServer clientLogLevel set to 'warning' I can still see the Am I doing something wrong? |
@leolozes creators of [HMR] love to spam many logs =) I just forked webpack and manually deleted all the logs |
Code
Expected Behavior
HMR info messages are not logged unless
clientLogLevel
is set toinfo
.Actual Behavior
The info message
[HMR] Waiting for update signal from WDS...
is always logged. Other logged messages work correctly.I believe this is caused by the
log-level
socket (which sets HMR log level) happening after the message is logged (location where it is logged)I'm not sure how this would be fixed but I'm happy to open a PR if someone has a solution and it isn't too difficult.
The text was updated successfully, but these errors were encountered: