Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR logging info message when clientLogLevel is not set to info #1195

Closed
1 of 3 tasks
josh18 opened this issue Nov 19, 2017 · 5 comments
Closed
1 of 3 tasks

HMR logging info message when clientLogLevel is not set to info #1195

josh18 opened this issue Nov 19, 2017 · 5 comments

Comments

@josh18
Copy link

josh18 commented Nov 19, 2017

  • Operating System: Windows
  • Node Version: 8.8.1
  • NPM Version: 5.4.2
  • webpack Version: 3.8.1
  • webpack-dev-server Version: 2.9.4
  • This is a bug
  • This is a feature request
  • This is a modification request

Code

// webpack.config.js
...
devServer: {
    clientLogLevel: 'warning',
    hot: true
}
...

Expected Behavior

HMR info messages are not logged unless clientLogLevel is set to info.

Actual Behavior

The info message [HMR] Waiting for update signal from WDS... is always logged. Other logged messages work correctly.


I believe this is caused by the log-level socket (which sets HMR log level) happening after the message is logged (location where it is logged)

I'm not sure how this would be fixed but I'm happy to open a PR if someone has a solution and it isn't too difficult.

@shellscape
Copy link
Contributor

We've got this fixed for the v3 beta branch, but would happily review a PR to resolve this for 2.x!

@josh18
Copy link
Author

josh18 commented Nov 20, 2017

Oh nice, thanks. I had a quick look at the v3 branch but couldn't figure out how it was fixed. I think I'll leave it for now as it is not that big of an issue especially if it is solved in v3.

Should I close this issue?

@shellscape
Copy link
Contributor

Well it still looks valid for 2.x, so I'd leave it open. And I don't see v3 being released before Feb.

@leolozes
Copy link

webpack Version: 4.28.3
webpack-dev-server Version: 3.1.14

with the devServer clientLogLevel set to 'warning' I can still see the [HMR] Waiting for update signal from WDS... message every time.

Am I doing something wrong?

@MaxmaxmaximusGitHub
Copy link

@leolozes creators of [HMR] love to spam many logs =) I just forked webpack and manually deleted all the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants