Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content base should have precedence over proxy #1131

Closed
jacobp100 opened this issue Oct 3, 2017 · 1 comment
Closed

Content base should have precedence over proxy #1131

jacobp100 opened this issue Oct 3, 2017 · 1 comment

Comments

@jacobp100
Copy link

If I have a proxy set up for /, I would expect it to take all unrecognised requests. However, the proxy has precedence over contentBase, so my requests are going to the proxy, which serves a 404 page.

Is this the intended behaviour?

if (options.proxy) { defaultFeatures.push('proxy', 'middleware'); }
if (contentBase !== false) { defaultFeatures.push('contentBaseFiles'); }

@jacobp100 jacobp100 changed the title Content Base should have precedence over proxy Content base should have precedence over proxy Oct 3, 2017
@shellscape
Copy link
Contributor

@jacobp100 if you see an issue template, they're usually not optional. it's also always a good idea to read their contents. closing as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants