Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node processes do not exit normally when CTRL+C (SIGINT) #1093

Closed
1 of 2 tasks
gaui opened this issue Sep 15, 2017 · 5 comments
Closed
1 of 2 tasks

Node processes do not exit normally when CTRL+C (SIGINT) #1093

gaui opened this issue Sep 15, 2017 · 5 comments

Comments

@gaui
Copy link

gaui commented Sep 15, 2017

Please note that this template is not optional. If you proceed with this form,
please fill out all fields, or your issue may be closed as "invalid."
Please do not delete this template. Please ask questions on StackOverflow or the
webpack Gitter (https://gitter.im/webpack/webpack). General questions, how-to
questions, and support requests will be closed.

Please do remove this header to acknowledge this message.

  • Operating System: Windows 10
  • Node Version: 8.5
  • NPM Version: yarn 1.0.1
  • webpack Version: 3.5.5
  • webpack-dev-server Version: 2.7.1
  • This is a feature request
  • This is a bug

Code

  // webpack.config.js
  // additional code, remove if not needed.

Expected Behavior

node.exe processes should exit and Webpack shouldn't trigger compile afterwards.

Actual Behavior

node.exe processes don't exit and Webpack triggers compile afterwards.

For Bugs; How can we reproduce the behavior?

Clone the repro repo with the appropriate Webpack/dev-server + Node version and follow these steps:
https://github.com/gaui/devserver-node-hang

# Install dependencies
yarn

# Run dev server
yarn dev

# Kill Webpack dev server and press CTRL+C

# Remove node_modules folder
rm -rf node_modules

Screencast of bug:

https://i.imgur.com/8oT04Nn.gif

For Features; What is the motivation and/or use-case for the feature?

@shellscape
Copy link
Contributor

Duplicate of #860

@shellscape shellscape marked this as a duplicate of #860 Sep 15, 2017
@gaui
Copy link
Author

gaui commented Sep 18, 2017

@shellscape Are you sure this is the same issue?

@h6ah4i describes it as:

Pressing Ctrl+C to stop webpack-dev-server does not work while compiling assets. (NOTE: Ctrl+C works well after finished compilation.)

In my case it doesn't completely kill Node processes after compiling assets.

@shellscape
Copy link
Contributor

My confidence is high. I believe the point at which the SIGINT actually kicks is in a red herring. The greater issue lies with Windows. If you'd like to add your specific series of events to that issue in a comment, please do :)

@gaui
Copy link
Author

gaui commented Sep 18, 2017

Ok thank you. :)

@nightlyop
Copy link

If you are using Git for Windows, that might be the problem: git-for-windows/git#1219 (There is workaround described in that link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants