-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index): don't modifiy the default behavior for unhandledRejection
#340
Conversation
This modules modifies the global promise/async rejection behaviour so no uncaught rejections will be swallowed.
loud-rejection
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
- Coverage 96.81% 96.8% -0.02%
=========================================
Files 7 7
Lines 251 250 -1
=========================================
- Hits 243 242 -1
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i am afraid what it is breaking change.
Thanks @HaNdTriX! @evilebottnawi I can't come up with a good reasoning as to why this would be a breaking change. I see this only as a bug, especially since in |
@SpaceK33z Agree, |
@evilebottnawi Fixed already, was writing the changelog by hand because I saw the new |
Wow that was fast. Thanks a lot 🙏! |
Why was this released as a |
@michael-ciniawsky this was a Anyway, as I said above here already I didn't know there was a |
loud-rejection
unhandledRejection
s
unhandledRejection
sunhandledRejection
unhandledRejection
unhandledRejection
loud-rejection modifies the global promise/async rejection behaviour so uncaught rejections will be swallowed. This PR removes loud-rejection.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
TBD
Summary
See: #339
Does this PR introduce a breaking change?
This PR introduces a breaking change since uncaught promises might end the process now.
Other information
Closes #339