Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support HEAD request as well #279

Closed
javenwang opened this issue Mar 5, 2018 · 3 comments
Closed

Should support HEAD request as well #279

javenwang opened this issue Mar 5, 2018 · 3 comments

Comments

@javenwang
Copy link

if (req.method !== 'GET') {
return goNext();
}

@evenstensberg
Copy link
Member

Could you elaborate a bit more in depth about this, maybe the problem you are trying to solve as well as how you'd think it should look like?

@shellscape
Copy link
Contributor

Closing as invalid, since the issue template was removed.

@michaek
Copy link

michaek commented Jul 26, 2018

It seems to me the original reporter is saying that HEAD requests should be handled as GET requests, just adding a req.method !== 'HEAD' to the conditional. It seems to me this wouldn't be harmful, but it may be nice to respond with empty content for a HEAD request. Currently I'm putting a another middleware in front of this to handle HEAD requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants