Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no crash when headers are already sent #1929

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1920

Breaking Changes

No

Additional Info

We don't generate 500 because you can use multiple dev middlewares

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (0f9a6c9) to head (33811fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
+ Coverage   96.16%   96.21%   +0.04%     
==========================================
  Files          13       13              
  Lines         861      871      +10     
  Branches      248      252       +4     
==========================================
+ Hits          828      838      +10     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit c20f1d9 into master Aug 21, 2024
14 checks passed
@alexander-akait alexander-akait deleted the fix-don't-crash-headers-sent branch August 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression from 7.2.1 to 7.3.0
1 participant