fix: ContentLength incorrectly set for empty files
#1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested review from
alexander-akait,
hiroppy and
snitin315
as code owners
A regression was introduced in the latest version wherein files with zero bytes would have their `ContentLength` erroneously set to `1`. This resulted in requests failing with an `ERR_CONTENT_LENGTH_MISMATCH`.
alexander-akait
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1785 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 10 10
Lines 465 465
Branches 136 137 +1
=======================================
Hits 452 452
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Thank you |
|
@alexander-akait, when should we expect this to be released? |
|
@alan-agius4 ~1 hour, want to finish fix with some types |
|
@alexander-akait, cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the latest version wherein files with zero bytes would have their
ContentLengtherroneously set to1. This resulted in requests failing with anERR_CONTENT_LENGTH_MISMATCH.