feat: progress supports string argument #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Oct 29, 2020
Comment on lines
+26
to
+28
| const isProfile = this.options.progress === 'profile'; | ||
|
|
||
| new ProgressPlugin({ profile: isProfile }).apply(compiler); |
There was a problem hiding this comment.
What if an invalid value is provided webpack --progress=invalid. Should we throw error ?
There was a problem hiding this comment.
Fixed, please review again
snitin315
reviewed
Oct 29, 2020
Co-authored-by: Nitin Kumar <[email protected]>
snitin315
approved these changes
Oct 29, 2020
snitin315
requested changes
Oct 30, 2020
Co-authored-by: Nitin Kumar <[email protected]>
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@evilebottnawi Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
snitin315
approved these changes
Oct 30, 2020
rishabh3112
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
request from @sokra
Does this PR introduce a breaking change?
No
Other information
No