Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass a callback to webpack from webpack-cli #1977

Merged
merged 12 commits into from
Oct 26, 2020
Merged

refactor: pass a callback to webpack from webpack-cli #1977

merged 12 commits into from
Oct 26, 2020

Conversation

piecyk
Copy link
Contributor

@piecyk piecyk commented Oct 22, 2020 •
edited
Loading

What kind of change does this PR introduce?

Refactor how webpack compiler is called from webpack-cli

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

Does this PR introduce a breaking change?

No

Other information

Part of #1918

@piecyk piecyk requested a review from a team as a code owner October 22, 2020 18:15
alexander-akait
alexander-akait reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One improvement, anyway good job!

@alexander-akait
Copy link
Member

Need fix tests and we can merge it, good job, thanks

@alexander-akait
Copy link
Member

@piecyk still broken on windows

@piecyk
Copy link
Contributor Author

piecyk commented Oct 23, 2020

Yep 😞 let's see if clearing .cache will help on windows 🤞 If not, have somewhere old windows laptop 🙈

alexander-akait
alexander-akait previously approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

anshumanv
anshumanv previously approved these changes Oct 24, 2020
View reviewed changes
snitin315
snitin315 reviewed Oct 25, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work?

packages/webpack-cli/lib/plugins/WebpackCLIPlugin.js Outdated Show resolved Hide resolved
packages/webpack-cli/lib/webpack-cli.js Outdated Show resolved Hide resolved
@piecyk
Copy link
Contributor Author

piecyk commented Oct 25, 2020

@snitin315 yes, it's the same. Thanks.

@piecyk piecyk dismissed stale reviews from anshumanv and alexander-akait via 40b202f October 25, 2020 10:02
snitin315
snitin315 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

alexander-akait
alexander-akait approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @anshumanv

@alexander-akait alexander-akait merged commit 2cb0c0e into webpack:master Oct 26, 2020
@alexander-akait
Copy link
Member

Thanks, try to do release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@anshumanv anshumanv anshumanv approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piecyk @alexander-akait @anshumanv @snitin315 @webpack-bot