fix: help and version functionality #1972
Conversation
snitin315
changed the title
| // Use customized help output if available | ||
| parser.on('option:help', () => { | ||
| // Use customized help output | ||
| if (args.includes('--help')) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch. It should be removed from there.
There was a problem hiding this comment.
The same should be done for version too.
snitin315
changed the title
| @@ -4,11 +4,6 @@ const { run } = require('../utils/test-utils'); | |||
| const helpHeader = 'The build tool for modern web applications'; | |||
|
|
|||
| describe('commands help', () => { | |||
| it('throws error if supplied as an argument for subcommands', () => { | |||
| const { stderr } = run(__dirname, ['serve', 'help'], false); | |||
There was a problem hiding this comment.
Supplying help as an argument to any of the subcommands shouldn't be allowed.
There was a problem hiding this comment.
I think we can allow it for consistency.
webpack --flag help - Allowed
webpack help --help - Allowed
webpack help cmd - Allowed
There was a problem hiding this comment.
webpack help --help interesting, but I think it is good
There was a problem hiding this comment.
oh!, I wanted to type webpack help --flag.
Just checked webpack help --help is allowed as well and is equivalent to webpack help
There was a problem hiding this comment.
@snitin315 Can we refactor this test to allow using help here
What kind of change does this PR introduce?
bugfix
Fixes #1917
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
No