fix(karma-webpack): ensure webpack output paths include a trailing slash
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to codymikol#297, the following paths would always end with a slash: - `webpackOptions.output.publicPath` - `webpackOptions.output.publicPath` - `webpackMiddlewareOptions.publicPath` Fixes codymikol#284
|
|
michael-ciniawsky
changed the title
output paths include a trailing slash
michael-ciniawsky
approved these changes
Dec 14, 2017
joshwiens
approved these changes
Dec 14, 2017
|
Happy to help 👍 |
|
@darsee - Available on npm as |
This was referenced Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #279, the following paths would always end with a slash:
webpackOptions.output.publicPathwebpackOptions.output.publicPathwebpackMiddlewareOptions.publicPathFixes #284
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
webpackOptions.output.publicPath,webpackOptions.output.publicPathandwebpackMiddlewareOptions.publicPathdo not always include a trailing slash, as they did prior to #279.What is the new behavior?
webpackOptions.output.publicPath,webpackOptions.output.publicPathandwebpackMiddlewareOptions.publicPathwill always include a trailing slash.Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: