fix: pass on error to callback for better error messages #262
Conversation
|
|
|
@michael-ciniawsky thanks, let me know if there is anything else I need to do to get this in 😃 |
|
@vinteo You need to sign the CLA please, close and reopen the PR to trigger the CLA Bot again |
|
@michael-ciniawsky I have signed it, its the travis that's not triggering or am I missing something? |
|
😅 Yeah... my bad all good 👍 |
|
@evilebottnawi There are no tests in this library so I wasn't fully sure where to start but I created a very simple test for this very specific scenario |
| @@ -0,0 +1,24 @@ | |||
| import {assert} from 'chai' | |||
There was a problem hiding this comment.
Let's avoid using unit directory for test file.
There was a problem hiding this comment.
It is an existing folder (for the demo test) and the current test config doesn't support it in the root test folder. What name do you suggest?
There was a problem hiding this comment.
@vinteo oh sorry, i think we update tests (migrate to jest) in this repo, do nothing, leave everything as is 👍
michael-ciniawsky
added
pr_action: Merge ready
status: Approved
and removed
pr_action: Review
labels
|
@vinteo - Can you rebase in latest master when you have a moment, solves the issue with Travis not running PRs |
|
@d3viant0ne done! 😃 |
|
Thanks :) |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bugfix
Duplicate of fix: return with
{Error}#215What is the new behavior?
A proper error is given
Does this PR introduce a breaking change?
Issues
PRs
{Error}#215