Webpack 2.2.0-rc.4 throws an error because karma-webpack passes incorrect entry option #193

Reinmar · 2017-01-11T16:53:31Z

I'm submitting a bug report

Webpack version:

2.2.0-rc.4

Webpack Karma version:

1.8.1

Karma version:

1.3.0

Please tell us about your environment:

OSX 10.12

Current behavior:

11 01 2017 17:47:50.284:ERROR [preprocess]: Can not load "webpack"!
  WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.entry should be one of these:
   object { <key>: non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function
   The entry point(s) of the compilation.
   Details:
    * configuration.entry should NOT have less than 1 properties ({
        "keyword": "minProperties",
        "dataPath": ".entry",
        "schemaPath": "#/oneOf/0/minProperties",
        "params": {
          "limit": 1
        },
        "message": "should NOT have less than 1 properties",
        "schema": 1,
        "parentSchema": {
          "minProperties": 1,
          "additionalProperties": {
            "oneOf": [
              {
                "description": "The string is resolved to a module which is loaded upon startup.",
                "minLength": 1,
                "type": "string"
              },
              {
                "description": "All modules are loaded upon startup. The last one is exported.",
                "$ref": "#/definitions/common.nonEmptyArrayOfUniqueStringValues"
              }
            ]
          },
          "description": "Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.",
          "type": "object"
        },
        "data": {}
      }).
      object { <key>: non-empty string | [non-empty string] }
      Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.
    * configuration.entry should be a string.
    * configuration.entry should be an array:
      [non-empty string]
    * configuration.entry should be an instance of function
      function returning an entry object or a promise..
    at webpack (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/webpack/lib/webpack.js:20:9)
    at new Plugin (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/karma-webpack/lib/karma-webpack.js:63:18)
    at invoke (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:75:15)
    at Array.instantiate (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:59:20)
    at get (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:48:43)
    at /www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:71:14
    at Array.map (native)
    at Array.invoke (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:70:31)
    at Injector.get (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/di/lib/injector.js:48:43)
    at instantiatePreprocessor (/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules/karma/lib/preprocessor.js:55:20)
    at Array.forEach (native)

Expected/desired behavior:

It worked fine with Webpack 2.2.0-rc.3. Webpack either hasn't been validating the entry option or the validation was more loose.

The config which karma-webpack passes to Webpack is this:

{ plugins: [ CKEditorWebpackPlugin { options: [Object] } ],
  module: { rules: [ [Object], [Object] ] },
  resolveLoader:
   { modules:
      [ 'node_modules',
        '/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules' ] },
  watch: true,
  entry: {},
  output:
   { path: '/_karma_webpack_/',
     publicPath: '/_karma_webpack_/',
     filename: '[name]',
     chunkFilename: '[id].bundle.js' } }

The important part is entry: {}.

The text was updated successfully, but these errors were encountered:

egoroof · 2017-01-11T16:57:10Z

I was first 😄

Reinmar · 2017-01-11T16:58:23Z

You mean #192? Perhaps it's the same issue, but there are no details what went wrong in your ticket.

Reinmar · 2017-01-11T16:59:37Z

Not sure if this is relevant, but here's the config which we pass to Karma:

{ basePath: '/www/ckeditor5/ckeditor5',
  frameworks: [ 'mocha', 'chai', 'sinon' ],
  files: [ '/www/ckeditor5/ckeditor5/node_modules/ckeditor5-autoformat/tests/**/*.js' ],
  exclude: [ '**/tests/**/_utils/**/*.js', '**/tests/**/manual/**/*.js' ],
  preprocessors: { '/www/ckeditor5/ckeditor5/node_modules/ckeditor5-autoformat/tests/**/*.js': [ 'webpack' ] },
  webpack:
   { plugins:
      [ CKEditorWebpackPlugin {
          options:
           { packages:
              [ '/www/ckeditor5/ckeditor5',
                '/www/ckeditor5/ckeditor5/node_modules' ] } } ],
     module:
      { rules:
         [ { test: /ckeditor5-[^\/]+\/theme\/icons\/[^\/]+\.svg$/,
             use: [ 'raw-loader' ] },
           { test: /\.scss$/,
             use: [ 'style-loader', 'css-loader', 'sass-loader' ] } ] },
     resolveLoader:
      { modules:
         [ 'node_modules',
           '/www/ckeditor5/ckeditor5-dev/packages/ckeditor5-dev-tests/node_modules' ] } },
  webpackMiddleware: { noInfo: true, stats: { chunks: false } },
  reporters: [ 'mocha' ],
  port: 9876,
  colors: true,
  logLevel: 'INFO',
  browsers: [ 'Chrome' ],
  customLaunchers: { CHROME_TRAVIS_CI: { base: 'Chrome', flags: [ '--no-sandbox' ] } },
  singleRun: true,
  concurrency: Infinity,
  browserNoActivityTimeout: 0 }

TheLarkInn · 2017-01-11T17:23:37Z

What if you pass entry: []? We did add more constraints on the entry property validation.

Reinmar · 2017-01-11T17:26:39Z

I added options.entry = []; in webpack.js:

function webpack(options, callback) {
	options.entry = [];
	
	...

And I got the same error.

Reinmar · 2017-01-11T17:29:18Z

A quick workaround can be to set options.entry to 'whatever' and besides:

ERROR in Entry module not found: Error: Can't resolve 'whatever' in '/www/ckeditor5/ckeditor5'

The tests run and pass :)

TheLarkInn · 2017-01-11T17:54:35Z

Could you make a tiny example of this for me to reproduce and add to test cases.

gyandeeps · 2017-01-11T18:49:31Z

Quick work around is

webpackOptions.entry = function(){return {}};

this way it works like it used to. This style was built for hot reloading stuff.
I dont know if this a good long term solution.

TheLarkInn · 2017-01-11T18:51:40Z

No this is exactly how we will fix it. Thank you for posting this workaround.

gyandeeps · 2017-01-11T18:52:41Z

Will send a PR. Thanks @TheLarkInn

joshwiens · 2017-01-11T19:03:19Z

@gyandeeps - Be mindful to open said pull request to https://github.com/webpack/karma-webpack/tree/v1 & not master. I'll land it as soon as it arrives.

gyandeeps · 2017-01-11T19:04:25Z

@d3viant0ne It took me a while to figure out why the index.js was empty. lol
here is the PR: #194

joshwiens · 2017-01-11T19:05:07Z

Already merged. @TheLarkInn will cut a patch release shortly

And thank you :)

gyandeeps · 2017-01-11T19:12:11Z

@d3viant0ne Please merge this PR #195 as I had some lint issues in previous one.

joshwiens · 2017-01-11T19:12:44Z

Already done. I'm quick with that little green button of doom :)

TheLarkInn · 2017-01-11T19:15:40Z

Before I publish, since I can't test this via our current suite, would someone mind running this commit against their build to ensure it works. I don't have a local reproducible example of this. // @Reinmar @egoroof @gyandeeps

gyandeeps · 2017-01-11T19:17:23Z

@TheLarkInn I actually tested it with my karma webpack (rc4) setup. That how I figured this out.
I have not tested it with old webpack.

joshwiens · 2017-01-11T19:21:48Z

@TheLarkInn - Verifying it now

TheLarkInn · 2017-01-11T19:24:16Z

Awesome thank you. Also @MikaAK You are the only one with privileges can you publish this?

TheLarkInn · 2017-01-11T19:24:31Z

I have the tags pushed and release commits pushed.

joshwiens · 2017-01-11T19:24:40Z

Besides the usual suspects, i.e. @sokra

gyandeeps · 2017-01-11T19:50:16Z

@TheLarkInn I saw u created a release but i am not seeing it here anymore: https://github.com/webpack/karma-webpack/releases

Even its not their on npm.

joshwiens · 2017-01-11T19:50:48Z

I removed the tag as it still throws the same error

gyandeeps · 2017-01-11T19:51:46Z

huh... it worked for me with webpack (rc4). Can you share your setup or any details.

joshwiens · 2017-01-11T19:58:34Z

Note to absolutely everyone who will run into this. Most common webpack test configurations set entry: {} to include all of mine.

When updating to "webpack": "2.2.0-rc.4" & "karma-webpack": "1.8.2" you have to pull the entry property if it's set to an empty object so it defaults to a function within karma-webpack and you don't beat your head against the desk and look like a total ass in a github issue like me :)

gyandeeps · 2017-01-11T20:00:23Z

ah i see. Should we just check if its an empty object (Object.keys(webpackOptions.entry).length === 0) then just replace it with function as well ?

joshwiens · 2017-01-11T20:01:16Z

I'll stick a note in the tag regarding the required change.

gyandeeps · 2017-01-11T20:04:09Z

I would recommend 0.9.0 tag release, so that people know that thr are some breaking changes.

joshwiens · 2017-01-11T20:06:48Z

It's a fix for a breaking change in Webpack ( technically ) not something I would cut a major for.

When using anything but rc.4 it behaves exactly as it did before as it's just failing on schema validation in Webpack.

gyandeeps · 2017-01-11T20:17:45Z

Sounds good. I will wait for npm to start showing me 1.8.2
Its been lil slow lately.

gyandeeps · 2017-01-11T20:34:48Z

@TheLarkInn @d3viant0ne Has this been released to npm ?
Its been an hour and it still shows 1.8.1
https://www.npmjs.com/package/karma-webpack

joshwiens · 2017-01-11T20:50:05Z

No, limited number or people with npm access. Taking care of that now.

- defaults webpackOptions.entry to a function BREAKING CHANGE: Remove entry:{} from test configurations When updating to `"webpack": "2.2.0-rc.4"` & `"karma-webpack": "1.8.2"` you have to pull the `entry` property if it's set to an empty object so it defaults to a function within karma-webpack

joshwiens · 2017-01-11T21:30:50Z

@gyandeeps - After a bit of discussion, the decision was made to make this a major after all.

Proper tag is cut here - https://github.com/webpack/karma-webpack/releases/tag/v2.0.1

@TheLarkInn should be pushing that up to npm shortly.

joshwiens · 2017-01-11T21:39:20Z

Resolving - https://www.npmjs.com/package/karma-webpack @ 2.0.1

siemiatj · 2017-01-13T14:01:50Z

For anyone who stumbles upon that. I've recently migrated to Webpack 2 but my karma config stayed the same. And now when I was trying to run my tests with webpack-karma 2.0.1 I was getting :

13 01 2017 14:45:10.390:ERROR [preprocess]: Can not load "webpack"!
  Error
    at webpack (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/webpack/lib/webpack.js:19:9)
    at new Plugin (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/karma-webpack/lib/karma-webpack.js:67:18)
    at invoke (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:75:15)
    at Array.instantiate (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:59:20)
    at get (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:48:43)
    at /Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:71:14
    at Array.map (native)
    at Array.invoke (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:70:31)
    at Injector.get (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:48:43)
    at instantiatePreprocessor (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/karma/lib/preprocessor.js:56:20)
    at Array.forEach (native)
    at createPreprocessor (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/karma/lib/preprocessor.js:75:20)
    at Array.invoke (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:75:15)
    at get (/Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:48:43)
    at /Users/sasklacz/Work/crowdspring/cs3/web/node_modules/di/lib/injector.js:71:14
    at Array.map (native)

which tells nothing at all. After some .console.log('foo') debugging it turned out that it was caused by an error in my karma.webpack config, but the error itself never bubbled up so it was hard to debug :

message: 'Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.\n - configuration.resolve.extensions[0] should not be empty.',

So be sure that your webpack config is correct before anything else :)

ghost · 2018-01-23T16:30:04Z

I have the same issue, updated here:
#227 (comment)

mantupani17 · 2018-03-06T09:13:28Z

i am having the same problem with webpack , i cant understand how do i resolve

mpavkovic · 2018-08-11T18:50:06Z

@mantupani17 Have you tried @gyandeeps solution? It worked for me. I've shortened it a bit by using arrow functions

webpackConfig.entry = () => ({});

TheLarkInn added awaiting response type: Bug labels Jan 11, 2017

TheLarkInn mentioned this issue Jan 11, 2017

Webpack 2 2.2.0-rc.4 throws error in test setup webpack/webpack#3909

Closed

TheLarkInn self-assigned this Jan 11, 2017

joshwiens pushed a commit that referenced this issue Jan 11, 2017

Fix: Webpack rc4 entry specific changes (fixes #193) (#194)

0f9a294

joshwiens self-assigned this Jan 11, 2017

joshwiens closed this as completed Jan 11, 2017

fstr mentioned this issue Jan 19, 2017

Webpack changed validation of config.entry NathanWalker/ng2-image-lazy-load#24

Closed

jeremyrajan mentioned this issue Nov 5, 2022

[Snyk] Security upgrade loader-utils from 1.1.0 to 2.0.3 jeremyrajan/karma-webpack#9

Open

Webpack 2.2.0-rc.4 throws an error because karma-webpack passes incorrect entry option #193

Webpack 2.2.0-rc.4 throws an error because karma-webpack passes incorrect entry option #193

Comments

Reinmar commented Jan 11, 2017

egoroof commented Jan 11, 2017

Reinmar commented Jan 11, 2017

Reinmar commented Jan 11, 2017

TheLarkInn commented Jan 11, 2017

Reinmar commented Jan 11, 2017 • edited Loading

Reinmar commented Jan 11, 2017

TheLarkInn commented Jan 11, 2017

gyandeeps commented Jan 11, 2017 • edited Loading

TheLarkInn commented Jan 11, 2017 • edited Loading

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017 • edited Loading

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

TheLarkInn commented Jan 11, 2017 • edited Loading

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

TheLarkInn commented Jan 11, 2017

TheLarkInn commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

joshwiens commented Jan 11, 2017

gyandeeps commented Jan 11, 2017

gyandeeps commented Jan 11, 2017 • edited Loading

joshwiens commented Jan 11, 2017

joshwiens commented Jan 11, 2017 • edited Loading

joshwiens commented Jan 11, 2017 • edited Loading

siemiatj commented Jan 13, 2017

ghost commented Jan 23, 2018

mantupani17 commented Mar 6, 2018

mpavkovic commented Aug 11, 2018

Reinmar commented Jan 11, 2017 •

edited

Loading

gyandeeps commented Jan 11, 2017 •

edited

Loading

TheLarkInn commented Jan 11, 2017 •

edited

Loading

joshwiens commented Jan 11, 2017 •

edited

Loading

TheLarkInn commented Jan 11, 2017 •

edited

Loading

gyandeeps commented Jan 11, 2017 •

edited

Loading

joshwiens commented Jan 11, 2017 •

edited

Loading

joshwiens commented Jan 11, 2017 •

edited

Loading