Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

feat: add build-started and build-finished events #122

Merged
merged 2 commits into from
May 9, 2018

Conversation

shellscape
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Users have requested events to be notified when a build starts and ends.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #122 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #122     +/-   ##
=======================================
+ Coverage   92.59%    93%   +0.4%     
=======================================
  Files           7      7             
  Lines         297    300      +3     
=======================================
+ Hits          275    279      +4     
+ Misses         22     21      -1
Impacted Files Coverage Δ
index.js 98.18% <100%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715c50e...d711a45. Read the comment docs.

@elisherer
Copy link
Contributor

elisherer commented May 9, 2018

Can I apply plugins to the compiler on 'build-start', or should It be done on "before-build-start"?
I'm asking because that way I could change webpack-serve-waitpage to apply the ProgressPlugin on it's own without asking the developer to do it.

Nevermind, just realized I could get the compiler(s) from the options passed to add.

@shellscape shellscape merged commit bc6c9d4 into master May 9, 2018
@shellscape shellscape deleted the feat/build-events branch May 9, 2018 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants