--require and -r options are broken

[jdalton]

Reposting as a new issue from #138 (comment):

Ok, after digging into this a bit the issue does appear to be a webpack-serve issue.

webpack-serve receives the -r or --require as options.flags but then does not pass them off to config-loader which expects a options.require.

Receiving as options.flags

webpack-serve/cli.js

Lines 71 to 74 in f7842c4

	const flags = Object.assign({}, cli.flags);
	const explorer = cosmiconfig('serve', {});
	const { config } = explorer.searchSync() || {};
	const options = merge({ flags }, config);

Still options.flags

webpack-serve/lib/options.js

Lines 59 to 62 in f7842c4

	const flags = opts.flags || {};
	const nodeVersion = parseInt(process.version.substring(1), 10);
	return load(opts).then((configs) => {

Passing to config-loader as options.require

webpack-serve/lib/config.js

Lines 60 to 86 in f7842c4

	const { compiler, config, require } = options;
	// if someone passed us a config Object, then just resolve that object
	// we're only going to load the config from file when we're given a file
	// to load
	if (isPlainObject(config) || Array.isArray(config)) {
	const result = [].concat(config).map((conf) => prepare(conf));
	return Promise.resolve(result);
	}
	// if a user has passed us a compiler directly, then pull the config from
	// the compiler and use that
	if (compiler) {
	let configs = [];
	if (compiler instanceof MultiCompiler) {
	const { compilers } = compiler;
	configs = compilers.map((c) => c.options);
	} else {
	configs = [compiler.options];
	}
	return Promise.resolve(configs);
	}
	const loaderOptions = {
	allowMissing: true,
	require,

[shellscape]

Resolved in 9ef5b29

[jdalton]

Thank you @shellscape!

[oles]

Awesome - thank you both ❤️

[alexperrault]

Thank you for the hard work !
@shellscape, any chance this hotfix could be released before the rest of the branch it is currently on (test/ava) ?

[shellscape]

@alexperrault no, sorry. Please have patience.

[jdalton]

Hi @shellscape!

Is there anything I can help with?

[shellscape]

Nope. https://github.com/webpack-contrib/webpack-serve/commits/master (and the PR that resolved this is displayed hovering directly above your last reply in this thread)

[jdalton]

Oh, I know it was merged 😋
I was more asking if there's anything I can help with to bump the release is all.

[shellscape]

@jdalton that's just a passive-aggressive alternative to asking when the release will be published. please refrain from that in the future, it is not welcome.