Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

output.comments default behavior changed #289

Closed
owiber opened this issue May 10, 2018 · 1 comment
Closed

output.comments default behavior changed #289

owiber opened this issue May 10, 2018 · 1 comment

Comments

@owiber
Copy link

owiber commented May 10, 2018

In 1.2.4, it looks like the default behavior of output.comments changed from false to /^\**!|@preserve|@license|@cc_on/ if extractComments is disabled (which is the default case).

This seems to be a result of: #250.

Was this intentional? For large files, the new default behavior has quite a large negative impact on speed and memory usage.

@alexander-akait
Copy link
Member

Yes it is expected, we should respect copyright and licenses of other developers. Also itry to read all license in you application, perhaps some of them are not in MIT and other you should provide license. Otherwise, you violate the license and the law. Therefore, the behavior has been changed.

You your known all you licenses and understand that they can be removed, use the options

uglifyOptions: {
        output: {
          comments: false
        }    
}

Also you can use extractComments: true it is extract comment to separable file. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants