Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing circular json #163

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

janlent1
Copy link
Contributor

When reading outputoptions, they can become circular. This fixes that and only requires necessary infos.

This PR contains a:

  • [ X] bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

When reading outputoptions, they can become circular.
This fixes that and only requires necessary infos.
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.27 🎉

Comparison is base (0e82467) 20.95% compared to head (bb77c29) 21.23%.

❗ Current head bb77c29 differs from pull request most recent head 8806022. Consider uploading reports for the commit 8806022 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   20.95%   21.23%   +0.27%     
==========================================
  Files           8        8              
  Lines         501      504       +3     
  Branches      105      108       +3     
==========================================
+ Hits          105      107       +2     
- Misses        347      348       +1     
  Partials       49       49              
Impacted Files Coverage Δ
src/index.js 60.00% <66.66%> (+0.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 71af48d into webpack-contrib:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants