Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more consistent cache #43

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Don't use path as part of cache keys, so files with same content do have one cache entry

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait force-pushed the fix-more-consistent-cache branch from 88fe159 to d5d89bf Compare December 19, 2018 13:20
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #43 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.02%     
==========================================
  Files           5        5              
  Lines         273      271       -2     
  Branches      107      106       -1     
==========================================
- Hits          269      267       -2     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 97.94% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd40cbc...d5d89bf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #43 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.02%     
==========================================
  Files           5        5              
  Lines         273      271       -2     
  Branches      107      106       -1     
==========================================
- Hits          269      267       -2     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 97.94% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd40cbc...d5d89bf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant