Use ignoreWarnings as stats.warningsFilter is deprecated
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 212 212
Branches 56 56
=========================================
Hits 212 212 Continue to review full report at Codecov.
|
| stats: { | ||
| warningsFilter: [/Failed to parse source map/], | ||
| }, | ||
| ignoreWarnings: [/Failed to parse source map/], |
There was a problem hiding this comment.
ignoreWarnings should be in stats options
There was a problem hiding this comment.
Not according to the output of Webpack. See webpack/webpack.js.org#3995 (comment)
There was a problem hiding this comment.
alexander-akait
approved these changes
Oct 17, 2020
|
Thanks |
|
@evilebottnawi: when webpack/webpack.js.org#4076 is merged the options link can be updated to be https://webpack.js.org/configuration/other-options/#ignorewarnings |
chenxsan
added a commit
to chenxsan/source-map-loader
that referenced
this pull request
Oct 18, 2020
The link `https://webpack.js.org/configuration/#options:~:text=ignoreWarnings` was added in webpack-contrib#129, I think the author used it as a workaround because the URL should be used here is blocked by this pull request webpack/webpack.js.org#4076. Now `#options:~:text=ignoreWarnings` was recognized as ID and webpack.js.org doesn't have it in the page which caused the failure of CI. This pull request removes the paragraph temporarily to fix CI for webpack.js.org. And we can add it back later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreWarningsasstats.warningsFilteris deprecated