Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRM working with MiniCssExtractPlugin.loader #296

Closed
ylacaute opened this issue Oct 17, 2018 · 3 comments
Closed

HRM working with MiniCssExtractPlugin.loader #296

ylacaute opened this issue Oct 17, 2018 · 3 comments

Comments

@ylacaute
Copy link

ylacaute commented Oct 17, 2018

Hi ! You will be happy to read me, this is not an issue !

I am able to use MiniCssExtractPlugin config with webpack-dev-server with hot reload working.

{
        test: /\.(css|sass|scss)$/,
        use: [{
          loader: MiniCssExtractPlugin.loader
        }, {
          loader: "css-loader"
        }, {
          loader: "sass-loader"
        }]
      },

No need to make a special condition on the loader, no more style-loader.
As I am not sure to fully understand HRM I prefer to not create PR :)

@alexander-akait
Copy link
Member

@ylacaute Plugin doesn't support HMR. Look in README: https://github.com/webpack-contrib/mini-css-extract-plugin

TODO:

HMR support

Feel free to send a PR

@ylacaute
Copy link
Author

I read the README, that is exactly why I am posting this.

Currently I setup a fresh project with Webpack 4 and I got the hot reloading WORKING on my SCSS files without the dev condition : I always use MiniCssExtractPlugin.loader and it works like a charm.

So, maybe I don't understand but I think your feature is already done, it's already working :)

@alexander-akait
Copy link
Member

Close in favor #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants