fix: allow for same filenames to be added #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthieu-foucault hey, would you be so kind and release this? 🤗 pretty please 🤗 |
|
Will do tomorrow :)
…On Sun, Mar 3, 2019, 14:39 Thomas Allmer ***@***.***> wrote:
@matthieu-foucault <https://github.com/matthieu-foucault> hey, would you
be so kind and release this? 🤗 pretty please 🤗
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#401 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACj0dsgOMu4XjmnZ5bAiNIJHlxzcXUArks5vTE8ggaJpZM4baBr9>
.
|
| @@ -65,7 +83,7 @@ function configToWebpackEntries(config) { | |||
|
|
|||
| const webpackEntries = {}; | |||
| filteredFiles.forEach((filePath) => { | |||
| webpackEntries[path.parse(filePath).name] = filePath; | |||
| webpackEntries[getPathKey(filePath)] = filePath; | |||
There was a problem hiding this comment.
Why do we need this?
Can't we just use filePath as the attribute key?
There was a problem hiding this comment.
this is the key that webpack uses internally... it does not like '/' in it...
also it is the url that get's displayed when you build... so if that is too long it's quite annoying 🙈
|
Can we merge this, please? |
|
✔️ Published under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #400
Additional Info
adds a hash to the webpack entry list so same filenames can exist.