Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma-webpack): disable karma watch; use webpack watch only #386

Merged
merged 1 commit into from
Jan 1, 2019

Conversation

daKmoR
Copy link
Collaborator

@daKmoR daKmoR commented Dec 29, 2018

This PR contains a:

  • bugfix

Motivation / Use-Case

currently, karmas watch retriggers builds and we have a debounce to mitigate that.
However, when watching is wanted that doesn't work.

=> so disable karma watch mode
=> get rid of the debounce
=> use only webpacks watch

@daKmoR
Copy link
Collaborator Author

daKmoR commented Dec 29, 2018

@LarsDenBakker can you pls test and verify that it solves your use case?

@LarsDenBakker
Copy link

Even with a bigger timeout, it still runs the tests multiple times for me after a small change.

@LarsDenBakker
Copy link

I think it's unrelated to the debounce, it looks like every so often it's spawning extra build processes and it just keeps growing.

@daKmoR
Copy link
Collaborator Author

daKmoR commented Dec 29, 2018

@LarsDenBakker so "ditching" karma watch all together lets us get rid of the full debounce and should also enable a better watch mode without duplicate builds.

can you pls check again :)

@LarsDenBakker
Copy link

Yep, that fixes it 👍

@daKmoR daKmoR force-pushed the fix/configureDebounce branch from 2a241a8 to d050d1e Compare December 29, 2018 17:30
@daKmoR daKmoR changed the title fix: allow to configure debounce time and increase default fix(karma-webpack): disable karma watch; use webpack watch only Dec 29, 2018
@daKmoR
Copy link
Collaborator Author

daKmoR commented Dec 29, 2018

@matthieu-foucault I updated the merge request and cleaned up the history.

I think once this is merged we should have another alpha release (together with the other unreleased fix) - can you make it happen pls 🤗

@ryanclark
Copy link
Collaborator

I’d merge but I’m on mobile. Thanks for the PR, awesome work!

@daKmoR
Copy link
Collaborator Author

daKmoR commented Jan 1, 2019

friendly reminder for this pull and release request 🤗

@matthieu-foucault
Copy link
Collaborator

matthieu-foucault commented Jan 1, 2019 via email

@matthieu-foucault matthieu-foucault merged commit 1696bfd into codymikol:next Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants