-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(karma-webpack): disable karma watch; use webpack watch only #386
Conversation
@LarsDenBakker can you pls test and verify that it solves your use case? |
Even with a bigger timeout, it still runs the tests multiple times for me after a small change. |
I think it's unrelated to the debounce, it looks like every so often it's spawning extra build processes and it just keeps growing. |
@LarsDenBakker so "ditching" karma watch all together lets us get rid of the full debounce and should also enable a better watch mode without duplicate builds. can you pls check again :) |
Yep, that fixes it 👍 |
2a241a8
to
d050d1e
Compare
@matthieu-foucault I updated the merge request and cleaned up the history. I think once this is merged we should have another alpha release (together with the other unreleased fix) - can you make it happen pls 🤗 |
I’d merge but I’m on mobile. Thanks for the PR, awesome work! |
friendly reminder for this pull and release request 🤗 |
Will take care of this later today
Le mar. 1 janv. 2019 à 07:53, Thomas Allmer <[email protected]> a
écrit :
… friendly reminder for this pull and release request 🤗
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#386 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACj0dtbjMJjVX9UWb_DWXA9e8Njam6CLks5u-4RhgaJpZM4ZknC7>
.
|
This PR contains a:
Motivation / Use-Case
currently, karmas watch retriggers builds and we have a debounce to mitigate that.
However, when watching is wanted that doesn't work.
=> so disable karma watch mode
=> get rid of the debounce
=> use only webpacks watch