fix(karma-webpack): Do not unify "colors" property if webpack "stats" is a string #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westeezy
added a commit
to krakenjs/grumbler-scripts
that referenced
this pull request
Nov 11, 2021
There seems to be a regression with the colors property in stats merging to the default karma-webpack config. The fix for rc5 is here: codymikol/karma-webpack#376 but it returned in 4.0.2 it seems. Rather than fix this we should wait til we move to webpack v5 and karma-webpack v5 which won't have this issue ideally.
westeezy
added a commit
to krakenjs/grumbler-scripts
that referenced
this pull request
Nov 11, 2021
There seems to be a regression with the colors property in stats merging to the default karma-webpack config. The fix for rc5 is here: codymikol/karma-webpack#376 but it returned in 4.0.2 it seems. Rather than fix this we should wait til we move to webpack v5 and karma-webpack v5 which won't have this issue ideally.
westeezy
added a commit
to krakenjs/grumbler-scripts
that referenced
this pull request
Nov 11, 2021
There seems to be a regression with the colors property in stats merging to the default karma-webpack config. The fix for rc5 is here: codymikol/karma-webpack#376 but it returned in 4.0.2 it seems. Rather than fix this we should wait til we move to webpack v5 and karma-webpack v5 which won't have this issue ideally.
westeezy
added a commit
to krakenjs/grumbler-scripts
that referenced
this pull request
Nov 11, 2021
There seems to be a regression with the colors property in stats merging to the default karma-webpack config. The fix for rc5 is here: codymikol/karma-webpack#376 but it returned in 4.0.2 it seems. Rather than fix this we should wait til we move to webpack v5 and karma-webpack v5 which won't have this issue ideally.
westeezy
added a commit
to krakenjs/grumbler-scripts
that referenced
this pull request
Nov 18, 2021
* chore: update packages - update eslint - update to use the @babel/eslint-parser to resolve imports properly from the import plugin - update all packages to recent versions - set `requireConfigFile` to false for @babel/eslint-parser to be able to scan older packages in `node_modules` * bump eslint-find-rules to new version * set find-eslint-rules to no error for now * bump flow to most recent * update jest to 27 * bump fs-extra to v10 * bump npm-check-updates to v12 * bump flow-typed to 3.4.0 * bump karma deps to latest and update config * bump react-eslint to latest * fix for ident and react/indent eslint clashing * lint fixes Re Karma: There seems to be a regression with the colors property in stats merging to the default karma-webpack config. The fix for rc5 is here: codymikol/karma-webpack#376 but it returned in 4.0.2 it seems. Rather than fix this we should wait til we move to webpack v5 and karma-webpack v5 which won't have this issue ideally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375